[Fix] vol_idx missing in snr_in_cc Tutorial #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was getting the same issue! Thanks @skoudoro 👍 |
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 119 119
Lines 14298 14298
Branches 2243 2243
=======================================
Hits 12215 12215
Misses 1575 1575
Partials 508 508 |
|
Yep. Makes sense. And thanks for all the other fixes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix
snr_in_cc.pytutorial. Since we are using 4d data for this tutorial,vol_idxwas missing onmedian_otsufunction. I use the opportunity to fix some pep8